[llvm-commits] [PATCH 3/3] Test case for readobj sections output. Part of fix for PR14723.

Sami Liedes sami.liedes at iki.fi
Thu Dec 27 16:28:51 PST 2012


On Thu, Dec 27, 2012 at 04:44:21PM -0700, Sean Silva wrote:
> Please try to keep test cases in the same patch that they add tests for.

Oh, sorry. I'll do that in the future :)

However for now I'm still not sure which patch I should merge the test
case patch with:

#1 is the actual bug fix
#2 modifies llvm-objdump to output sections
#3 is a test that verifies both #1 and #2

So, which of these should I preferably send:

a) #2, then a patch combining #1+#3
b) #1, then a patch combining #2+#3
c) A single patch combining #1+#2+#3

Or should I try to avoid writing a test case that depends on both an
actual bug fix and changes to a tool to expose that bug?

	Sami



More information about the llvm-commits mailing list