[llvm-commits] [llvm] r170996 - /llvm/trunk/lib/Target/X86/X86FrameLowering.cpp

[David Blaikie]

On Sat, Dec 22, 2012 at 11:30 PM, Nadav Rotem <nrotem at apple.com> wrote:
> Author: nadav
> Date: Sun Dec 23 01:30:09 2012
> New Revision: 170996
>
> URL: http://llvm.org/viewvc/llvm-project?rev=170996&view=rev
> Log:
> Rename a function.
>
> Modified:
>     llvm/trunk/lib/Target/X86/X86FrameLowering.cpp
>
> Modified: llvm/trunk/lib/Target/X86/X86FrameLowering.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FrameLowering.cpp?rev=170996&r1=170995&r2=170996&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/X86FrameLowering.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86FrameLowering.cpp Sun Dec 23 01:30:09 2012
> @@ -625,12 +625,12 @@
>    return CompactUnwindEncoding;
>  }
>
> -/// colobbersTheStack - This function checks if any of the users of EFLAGS
> +/// usesTheStack - This function checks if any of the users of EFLAGS

When making changes like this you could update the doxygen style to
the new LLVM recommended format, using \brief without naming the
function/class being documented so that it would never have to be
updated again.

>  /// copies the EFLAGS. We know that the code that lowers COPY of EFLAGS has
>  /// to use the stack, and if we don't adjust the stack we clobber the first
>  /// frame index.
> -/// See  X86InstrInfo::copyPhysReg.
> -static bool colobbersTheStack(MachineFunction &MF) {
> +/// See X86InstrInfo::copyPhysReg.
> +static bool usesTheStack(MachineFunction &MF) {
>    MachineRegisterInfo &MRI = MF.getRegInfo();
>
>    for (MachineRegisterInfo::reg_iterator ri = MRI.reg_begin(X86::EFLAGS),
> @@ -696,7 +696,7 @@
>        !MFI->hasVarSizedObjects() &&                     // No dynamic alloca.
>        !MFI->adjustsStack() &&                           // No calls.
>        !IsWin64 &&                                       // Win64 has no Red Zone
> -      !colobbersTheStack(MF) &&                         // Don't push and pop.
> +      !usesTheStack(MF) &&                              // Don't push and pop.
>        !MF.getTarget().Options.EnableSegmentedStacks) {  // Regular stack
>      uint64_t MinSize = X86FI->getCalleeSavedFrameSize();
>      if (HasFP) MinSize += SlotSize;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits