[llvm-commits] [PATCH] Teach the inline cost analysis to forward stores of constants in the caller to loads in the callee.
Joey Gouly
joey.gouly at arm.com
Thu Dec 27 05:25:18 PST 2012
================
Comment at: lib/Analysis/InlineCost.cpp:650
@@ +649,3 @@
+
+ // Find a constant stored in the caller at this offset and stile live here.
+ StoredConstantsMapTy::iterator BasePtrI = StoredConstants.find(BasePtr);
----------------
Typo "stile".
================
Comment at: lib/Analysis/InlineCost.cpp:833
@@ +832,3 @@
+ // FIXME: We can do better than this for memset, memcpy, etc.
+ if (CS.onlyReadsMemory())
+ StoredConstants.clear();
----------------
Should this be !CS.onlyReadsMemory() ?
http://llvm-reviews.chandlerc.com/D246
More information about the llvm-commits
mailing list