[llvm-commits] [PATCH] [ASan] fix lifetime intrinsics handling

Kostya Serebryany kcc at google.com
Wed Dec 26 04:56:49 PST 2012



================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1358
@@ +1357,3 @@
+      if (IncValueAI == 0 || (Res != 0 && IncValueAI != Res)) {
+        Res = 0;
+        break;
----------------
return 0? 

================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:328
@@ +327,3 @@
+  typedef DenseMap<AllocaInst*, AllocaPoisonCallVec> AllocaPoisonCallsMapTy;
+  AllocaPoisonCallsMapTy AllocaPoisonCalls;
+
----------------
do you really need this map? 
w/o it things may become simpler


http://llvm-reviews.chandlerc.com/D244



More information about the llvm-commits mailing list