[llvm-commits] [llvm] r171078 - /llvm/trunk/lib/Target/X86/X86InstrInfo.cpp

[Nadav Rotem]

These are also vex-prefixed so they should also be set to zero. 

On Dec 25, 2012, at 5:02 PM, Craig Topper <craig.topper at gmail.com> wrote:

> What happened to this section?
> 
>     { X86::VFsANDNPDrr,       X86::VFsANDNPDrm,        TB_ALIGN_16 },
>     { X86::VFsANDNPSrr,       X86::VFsANDNPSrm,        TB_ALIGN_16 },
>     { X86::VFsANDPDrr,        X86::VFsANDPDrm,         TB_ALIGN_16 },
>     { X86::VFsANDPSrr,        X86::VFsANDPSrm,         TB_ALIGN_16 },
>     { X86::VFsORPDrr,         X86::VFsORPDrm,          TB_ALIGN_16 },
>     { X86::VFsORPSrr,         X86::VFsORPSrm,          TB_ALIGN_16 },
>     { X86::VFsXORPDrr,        X86::VFsXORPDrm,         TB_ALIGN_16 },
>     { X86::VFsXORPSrr,        X86::VFsXORPSrm,         TB_ALIGN_16 },
>     { X86::VHADDPDrr,         X86::VHADDPDrm,          TB_ALIGN_16 },
>     { X86::VHADDPSrr,         X86::VHADDPSrm,          TB_ALIGN_16 },
>     { X86::VHSUBPDrr,         X86::VHSUBPDrm,          TB_ALIGN_16 },
>     { X86::VHSUBPSrr,         X86::VHSUBPSrm,          TB_ALIGN_16 },
>     { X86::Int_VCMPSDrr,      X86::Int_VCMPSDrm,       0 },
>     { X86::Int_VCMPSSrr,      X86::Int_VCMPSSrm,       0 },
>     { X86::VMAXPDrr,          X86::VMAXPDrm,           TB_ALIGN_16 },
>     { X86::VMAXPDrr_Int,      X86::VMAXPDrm_Int,       TB_ALIGN_16 },
>     { X86::VMAXPSrr,          X86::VMAXPSrm,           TB_ALIGN_16 },
>     { X86::VMAXPSrr_Int,      X86::VMAXPSrm_Int,       TB_ALIGN_16 },
>     { X86::VMAXSDrr,          X86::VMAXSDrm,           0 },
>     { X86::VMAXSDrr_Int,      X86::VMAXSDrm_Int,       0 },
>     { X86::VMAXSSrr,          X86::VMAXSSrm,           0 },
>     { X86::VMAXSSrr_Int,      X86::VMAXSSrm_Int,       0 },
>     { X86::VMINPDrr,          X86::VMINPDrm,           TB_ALIGN_16 },
>     { X86::VMINPDrr_Int,      X86::VMINPDrm_Int,       TB_ALIGN_16 },
>     { X86::VMINPSrr,          X86::VMINPSrm,           TB_ALIGN_16 },
>     { X86::VMINPSrr_Int,      X86::VMINPSrm_Int,       TB_ALIGN_16 },
>     { X86::VMINSDrr,          X86::VMINSDrm,           0 },
>     { X86::VMINSDrr_Int,      X86::VMINSDrm_Int,       0 },
>     { X86::VMINSSrr,          X86::VMINSSrm,           0 },
>     { X86::VMINSSrr_Int,      X86::VMINSSrm_Int,       0 },
>     { X86::VMPSADBWrri,       X86::VMPSADBWrmi,        TB_ALIGN_16 },
>     { X86::VMULPDrr,          X86::VMULPDrm,           TB_ALIGN_16 },
>     { X86::VMULPSrr,          X86::VMULPSrm,           TB_ALIGN_16 },
> 
> On Tue, Dec 25, 2012 at 4:57 PM, Nadav Rotem <nrotem at apple.com> wrote:
> Thanks.  We also need to look at the FMA instructions.
> 
> On Dec 25, 2012, at 4:35 PM, Craig Topper <craig.topper at gmail.com> wrote:
> 
> > Author: ctopper
> > Date: Tue Dec 25 18:35:47 2012
> > New Revision: 171078
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=171078&view=rev
> > Log:
> > Remove alignment requirement from VCVTSS2SD in folding tables. Reverting r171049. This instruction doesn't require alignment.
> >
> > Modified:
> >    llvm/trunk/lib/Target/X86/X86InstrInfo.cpp
> >
> > Modified: llvm/trunk/lib/Target/X86/X86InstrInfo.cpp
> > URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrInfo.cpp?rev=171078&r1=171077&r2=171078&view=diff
> > ==============================================================================
> > --- llvm/trunk/lib/Target/X86/X86InstrInfo.cpp (original)
> > +++ llvm/trunk/lib/Target/X86/X86InstrInfo.cpp Tue Dec 25 18:35:47 2012
> > @@ -852,8 +852,8 @@
> >     { X86::Int_VCVTSI2SS64rr, X86::Int_VCVTSI2SS64rm,  0 },
> >     { X86::VCVTSI2SSrr,       X86::VCVTSI2SSrm,        0 },
> >     { X86::Int_VCVTSI2SSrr,   X86::Int_VCVTSI2SSrm,    0 },
> > -    { X86::VCVTSS2SDrr,       X86::VCVTSS2SDrm,        TB_ALIGN_16 },
> > -    { X86::Int_VCVTSS2SDrr,   X86::Int_VCVTSS2SDrm,    TB_ALIGN_16 },
> > +    { X86::VCVTSS2SDrr,       X86::VCVTSS2SDrm,        0 },
> > +    { X86::Int_VCVTSS2SDrr,   X86::Int_VCVTSS2SDrm,    0 },
> >     { X86::VCVTTPD2DQrr,      X86::VCVTTPD2DQXrm,      0 },
> >     { X86::VCVTTPS2DQrr,      X86::VCVTTPS2DQrm,       0 },
> >     { X86::VRSQRTSSr,         X86::VRSQRTSSm,          0 },
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> 
> 
> 
> -- 
> ~Craig

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121225/29435c5f/attachment.html>