[llvm-commits] [PATCH] [msan] MemorySanitizer unit tests.

[Evgeniy Stepanov]

================
Comment at: cmake/Modules/CompilerRTCompile.cmake:21
@@ +20,3 @@
+#                   OBJECTS <list of input objects>
+#                   LINKFLAGS <list of link flags>
+#                   DEPS <list of dependencies>)
----------------
Alexey Samsonov wrote:
> I think for clarity you can use format
> clang_link_shared(<output.so> OBJECTS <list of inputs> FLAGS <link flags> DEPS <deps>),
> and then 
> parse_arguments(LINK "OBJECS;FLAGS;DEPS" "" ${ARGN})
> so you'll have reasonable variables
> LINK_OBJECTS, LINK_FLAGS and LINK_DEPS.
Then callers would need to pass just "FLAGS" which is not clear at all.


================
Comment at: lib/msan/CMakeLists.txt:30
@@ +29,3 @@
+set(MSAN_LIBCXX_CFLAGS
+  -I${MSAN_LIBCXX_PATH}/include
+  -fsanitize=memory
----------------
Alexey Samsonov wrote:
> You have MSAN_LIBCXX_INCLUDE_CFLAGS
Not any longer )


http://llvm-reviews.chandlerc.com/D236