[llvm-commits] [compiler-rt] r171057 - in /compiler-rt/trunk/lib/sanitizer_common/tests: sanitizer_common_test.cc sanitizer_flags_test.cc

[Dmitry Vyukov]

Author: dvyukov
Date: Tue Dec 25 03:20:58 2012
New Revision: 171057

URL: http://llvm.org/viewvc/llvm-project?rev=171057&view=rev
Log:
tsan: fix tests to consistently use internal functions (otherwise it leads to false positives)

Modified:
    compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_common_test.cc
    compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_flags_test.cc

Modified: compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_common_test.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_common_test.cc?rev=171057&r1=171056&r2=171057&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_common_test.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_common_test.cc Tue Dec 25 03:20:58 2012
@@ -72,7 +72,7 @@
         uptr res = (uptr)MmapAlignedOrDie(
             size * PageSize, alignment * PageSize, "MmapAlignedOrDieTest");
         EXPECT_EQ(0U, res % (alignment * PageSize));
-        memset((void*)res, 1, size * PageSize);
+        internal_memset((void*)res, 1, size * PageSize);
         UnmapOrDie((void*)res, size * PageSize);
       }
     }

Modified: compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_flags_test.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_flags_test.cc?rev=171057&r1=171056&r2=171057&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_flags_test.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_flags_test.cc Tue Dec 25 03:20:58 2012
@@ -12,6 +12,7 @@
 //===----------------------------------------------------------------------===//
 #include "sanitizer_common/sanitizer_common.h"
 #include "sanitizer_common/sanitizer_flags.h"
+#include "sanitizer_common/sanitizer_libc.h"
 #include "gtest/gtest.h"
 
 #include <string.h>
@@ -31,7 +32,7 @@
                         const char *final_value) {
   const char *flag = start_value;
   ParseFlag(env, &flag, kFlagName);
-  EXPECT_STREQ(final_value, flag);
+  EXPECT_EQ(internal_strcmp(final_value, flag), 0);
 }
 
 TEST(SanitizerCommon, BooleanFlags) {