[llvm-commits] [compiler-rt] r171052 - in /compiler-rt/trunk/lib/asan: asan_internal.h tests/asan_noinst_test.cc

[Kostya Serebryany]

Yes, this has been there for quite a while.
Not a great trouble, but we were probably missing some rare bugs.

The redzone setting should soon become less important since I plan to
implement adaptive redzones.




On Tue, Dec 25, 2012 at 11:32 AM, Alexey Samsonov <samsonov at google.com>wrote:

>
> On Tue, Dec 25, 2012 at 11:29 AM, Kostya Serebryany <kcc at google.com>wrote:
>
>>
>>
>>
>> On Tue, Dec 25, 2012 at 11:26 AM, Alexey Samsonov <samsonov at google.com>wrote:
>>
>>> On Tue, Dec 25, 2012 at 11:17 AM, Kostya Serebryany <kcc at google.com>wrote:
>>>
>>>> Author: kcc
>>>> Date: Tue Dec 25 01:17:17 2012
>>>> New Revision: 171052
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=171052&view=rev
>>>> Log:
>>>> [asan] properly define ASAN_LOW_MEMORY. Due to a mistake it has been
>>>> always true causing redzone and quarantine sizes to be smaller than it was
>>>> some time before (and out of sync with the documentation). Also make one
>>>> test less greedy
>>>>
>>>
>>> OMG. Changing allocator brings unexpected benefits.
>>>
>>
>> OMG indeed.
>>
>
> FTR this code is in 3.2 release.
>
>
>>  Modified:
>>>>     compiler-rt/trunk/lib/asan/asan_internal.h
>>>>     compiler-rt/trunk/lib/asan/tests/asan_noinst_test.cc
>>>>
>>>> Modified: compiler-rt/trunk/lib/asan/asan_internal.h
>>>> URL:
>>>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_internal.h?rev=171052&r1=171051&r2=171052&view=diff
>>>>
>>>> ==============================================================================
>>>> --- compiler-rt/trunk/lib/asan/asan_internal.h (original)
>>>> +++ compiler-rt/trunk/lib/asan/asan_internal.h Tue Dec 25 01:17:17 2012
>>>> @@ -83,9 +83,9 @@
>>>>  // If set, values like allocator chunk size, as well as defaults for
>>>> some flags
>>>>  // will be changed towards less memory overhead.
>>>>  #ifndef ASAN_LOW_MEMORY
>>>> -# ifdef ASAN_ANDROID
>>>> +#if SANITIZER_WORDSIZE == 32
>>>>  #  define ASAN_LOW_MEMORY 1
>>>> -# else
>>>> +#else
>>>>  #  define ASAN_LOW_MEMORY 0
>>>>  # endif
>>>>  #endif
>>>>
>>>> Modified: compiler-rt/trunk/lib/asan/tests/asan_noinst_test.cc
>>>> URL:
>>>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/tests/asan_noinst_test.cc?rev=171052&r1=171051&r2=171052&view=diff
>>>>
>>>> ==============================================================================
>>>> --- compiler-rt/trunk/lib/asan/tests/asan_noinst_test.cc (original)
>>>> +++ compiler-rt/trunk/lib/asan/tests/asan_noinst_test.cc Tue Dec 25
>>>> 01:17:17 2012
>>>> @@ -508,7 +508,7 @@
>>>>    EXPECT_DEATH(DoLargeMallocForGetFreeBytesTestAndDie(),
>>>> "double-free");
>>>>  }
>>>>
>>>> -static const size_t kManyThreadsMallocSizes[] = {5, 1UL<<10, 1UL<<20,
>>>> 357};
>>>> +static const size_t kManyThreadsMallocSizes[] = {5, 1UL<<10, 1UL<<14,
>>>> 357};
>>>>  static const size_t kManyThreadsIterations = 250;
>>>>  static const size_t kManyThreadsNumThreads =
>>>>    (SANITIZER_WORDSIZE == 32) ? 40 : 200;
>>>> @@ -520,6 +520,8 @@
>>>>        free(Ident(malloc(kManyThreadsMallocSizes[size_index])));
>>>>      }
>>>>    }
>>>> +  // Just one large allocation.
>>>> +  free(Ident(malloc(1 << 20)));
>>>>    return 0;
>>>>  }
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>
>>>
>>>
>>>
>>> --
>>> Alexey Samsonov, MSK
>>>
>>>
>>
>
>
> --
> Alexey Samsonov, MSK
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121225/a8bea660/attachment.html>