[llvm-commits] [lld] Patch for ReaderELF and Symbol Resolution

Shankar Easwaran shankare at codeaurora.org
Fri Dec 21 13:07:03 PST 2012


On 12/20/2012 8:05 PM, Nick Kledzik wrote:
> On Dec 20, 2012, at 1:53 PM, Shankar Easwaran wrote:
>
>> Hi,
>>
>> This is the first set of diff's for the changes to lld Helloworld bringup.
>>
>> The  changes are attached as part of this mail.
>>
>> Includes :
>>
>> 1) A test case
>> 2) Diff for ReaderELF and SymbolTable changes
>> 3) Modified test for phdr
> Why should having multiple  absolute symbols with different values be ok?  I thought we did a fix a while back to allow multiple non-global absolute symbols with the same name.  But global absolute symbols still had to have unique names.  What is his allowing?
>
> -Nick
It looks like I had not synced the sources when I initially wrote. Now 
its all ok. I am reverting the changes for SymbolTable.

Ok to commit ?

Thanks

Shankar Easwaran


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation




More information about the llvm-commits mailing list