[llvm-commits] Additional value types - Please review

Nadav Rotem nrotem at apple.com
Thu Dec 20 12:42:05 PST 2012


In principal it LGTM. However I found a few glitches. 

For example:
+def v32i1  : ValueType<32 , 17>;   // 16 x i1  vector value
+def v64i1  : ValueType<64 , 18>;   // 16 x i1  vector value

The comments here are incorrect. 

+def v4f64  : ValueType<256, 47>;   //  4 x f64 vector value
+def v8f64  : ValueType<512, 48>;   //  4 x f64 vector value

Also here.

Please review this carefully before committing. 

Thanks,
Nadav

On Dec 20, 2012, at 6:23 AM, "Demikhovsky, Elena" <elena.demikhovsky at intel.com> wrote:

> 
> Hi,
> 
> I want to add some value types, like v32i1, v64i1.
> Thanks.
> 
> - Elena
> 
> 
> ---------------------------------------------------------------------
> Intel Israel (74) Limited
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> <vtypes.diff>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list