[llvm-commits] [PATCH] Rework CMake rules for building ASan unittests

[Chandler Carruth]

  Looks good. A couple of nits below, but submit whenever.


================
Comment at: cmake/Modules/CompilerRTUnittests.cmake:13
@@ +12,3 @@
+# test_suite.
+# add_compiler_rt(<test_suite> <test_name>
+#                 OBJECTS <object files>
----------------
add_compiler_rt_test

================
Comment at: lib/asan/tests/CMakeLists.txt:91
@@ +90,3 @@
+                CFLAGS ${ARGN}
+                DEPS gtest ${ASAN_RUNTIME_LIBRARIES}
+                            ${ASAN_BLACKLIST_FILE})
----------------
nit: If this doesn't fit on one line, i think the second's indent is a space off..


http://llvm-reviews.chandlerc.com/D188

BRANCH
  svn

ARCANIST PROJECT
  compiler-rt