So, I had quite a few comments on style of the this function that you've not addressed... I don't really care whether these are addressed before or after review, but they should be addressed. http://llvm-reviews.chandlerc.com/D208