[llvm-commits] [llvm] r170350 - /llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp

[Chandler Carruth]

On Mon, Dec 17, 2012 at 12:48 PM, Tim Northover <t.p.northover at gmail.com>wrote:

> > While your next commit probably exercises this, is it possible to test it
> > independently? Just curious.
>
> This patch is actually fixing a regression I introduced into ARM MCJIT
> on ELF (the first symbol in a section had ST_Unknown, so .text wasn't
> marked executable and execution segfaulted), which is why there are no
> explicit tests here. A regression test run on ARM Linux would pick it
> up.
>

Ah, nice! This would make an excellent addition to future commit logs
fwiw...


> Do you know of any RuntimeDyld tests that aren't target-specific? In
> principle we could have a unittest that loaded a provided object and
> checked the sections created (with a custom memorymanager?). There
> doesn't appear to be much precedent for that approach though.
>

Sadly, no... =/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121217/d3465b41/attachment.html>