[llvm-commits] [PATCH] [msan] Heuristic handling of unknown intrinsics
Evgeniy Stepanov
eugenis at google.com
Mon Dec 17 08:08:36 PST 2012
================
Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:1291
@@ +1290,3 @@
+ if (!handleUnknownIntrinsic(I))
+ visitInstruction(I);
+ break;
----------------
Alexander Potapenko wrote:
> I suggest putting this on the same line with if. Leaving the decision up to you
I prefer them on separate lines. Both functions are not trivial, putting them on the same line make it look too simple.
http://llvm-reviews.chandlerc.com/D184
More information about the llvm-commits
mailing list