[llvm-commits] addendum to patch for mips16 exception - please review

Reed Kotler rkotler at mips.com
Sun Dec 16 09:06:51 PST 2012


I need review before submitting patches outside of the Mips target.

On my previous patch for mips16 exception handling, I did not add the 
function body for EmitDebugLabel in MCPureStreamer. This only was caught
in one of the debian build flavors where a link error in Clang occurred.
Someone took out the EmitDebugLabel in MCPureStreamer and that fixed the 
build error but if someone is really using McPureStreamer, then we need 
to fix this correctly. By just taking out the EmitDebugLabel, that will 
make EmitDebugLabel from the parent class apply and that would be
incorrect here.

See attached patch.

I think this is safe and is really covered by my initial approval for 
the mips16 exception patch but I would prefer if someone reviews it.
-------------- next part --------------
diff --git a/lib/MC/MCPureStreamer.cpp b/lib/MC/MCPureStreamer.cpp
index 5529759..ca559b7 100644
--- a/lib/MC/MCPureStreamer.cpp
+++ b/lib/MC/MCPureStreamer.cpp
@@ -37,6 +37,7 @@ public:
 
   virtual void InitSections();
   virtual void EmitLabel(MCSymbol *Symbol);
+  virtual void EmitDebugLabel(MCSymbol *Symbol);
   virtual void EmitZerofill(const MCSection *Section, MCSymbol *Symbol = 0,
                             uint64_t Size = 0, unsigned ByteAlignment = 0);
   virtual void EmitBytes(StringRef Data, unsigned AddrSpace);
@@ -135,6 +136,10 @@ void MCPureStreamer::EmitLabel(MCSymbol *Symbol) {
 }
 
 
+void MCPureStreamer::EmitDebugLabel(MCSymbol *Symbol) {
+  EmitLabel(Symbol);
+}
+
 void MCPureStreamer::EmitZerofill(const MCSection *Section, MCSymbol *Symbol,
                                   uint64_t Size, unsigned ByteAlignment) {
   report_fatal_error("not yet implemented in pure streamer");


More information about the llvm-commits mailing list