[llvm-commits] [llvm] r170036 - in /llvm/trunk: include/llvm/Support/YAMLTraits.h lib/Support/YAMLTraits.cpp

[Nick Kledzik]

On Dec 15, 2012, at 1:44 AM, Benjamin Kramer wrote:
> On 15.12.2012, at 01:17, Michael Spencer <bigcheesegs at gmail.com> wrote:
>> On Thu, Dec 13, 2012 at 3:04 PM, Nick Kledzik <kledzik at apple.com> wrote:
>>> My trait stuff that I committed yesterday builds with clang and Visual Studio, but was failing with gcc-4.x on various *nix platforms.  To unblock the build  bots, I used #if 0 to conditionalize away the failing test cases in unittests/Support/YAMLIOTest.cpp.
>>> 
>>> I reconfigured llvm to build with an old llvm-gcc-4.2 compiler I have, and saw many compilation errors with YAMLIOTest.cpp.  I used some different SFINAE techniques and now have trait testing that works with gcc-4.2 and clang.
>>> 
>>> Ben and Michael, could you try putting in this new include/llvm/Support/YAMLTraits.h, enabling the tests in unittests/Support/YAMLIOTest.cpp, and build SupportTests with your compiler to verify these traits work?  Thanks!
>> 
>> Works on recent clang and MSVC 2012 Update 1.
> 
> Also compiles with GCC 4.2, 4.4 and 4.8.


Thanks!!

-Nick