[llvm-commits] [llvm] r170088 - /llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

[Nadav Rotem]

It looks like Rafael's 170095 is to blame.


On Dec 12, 2012, at 8:59 PM, Nadav Rotem <nrotem at apple.com> wrote:

> 
> Eric, 
> 
> I am seeing these failures (below) on PPC64, and they look related to debug info. Is it possible that one of your commits broke these tests ?
> 
> Thanks,
> Nadav
> 
> 	• llvm-ppc64-linux1: test llvm 6855 tests 6830 passed 52 warnings 25 failed failed -  stdiofailxfailunsupporteddw_at_byte_size.ll2011-12-16-badstructref.lldw_at_specification.lldw_tag_friend.lldw_at_object_pointer.llblock-capture.llempty-and-one-elem-array.llempty-array.llending-run.llenum-fwd-decl.llenum-class.lllinkage-name.llnondefault-subrange-array.lllow-pc-cu.llobjc-fwd-decl.llpointer-type-size.llop_deref.llpr11300.llrvalue-ref.llstruct-loc.ll
> 	• llvm-ppc64-linux2: test llvm 6855 tests 6830 passed 52 warnings 25 failed failed -  stdiofailxfailunsupporteddw_at_byte_size.ll2011-12-16-badstructref.lldw_at_specification.lldw_at_object_pointer.lldw_tag_friend.llblock-capture.llempty-array.llempty-and-one-elem-array.llending-run.llenum-class.llenum-fwd-decl.lllow-pc-cu.lllinkage-name.llnondefault-subrange-array.llobjc-fwd-decl.llpointer-type-size.llpr11300.llop_deref.llrvalue-ref.llstruct-loc.ll
> 
> On Dec 12, 2012, at 7:00 PM, Eric Christopher <echristo at gmail.com> wrote:
> 
>> Author: echristo
>> Date: Wed Dec 12 21:00:38 2012
>> New Revision: 170088
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=170088&view=rev
>> Log:
>> Use default label name for a section in emitting abbreviation
>> section to help prep some code to be split about.
>> 
>> Modified:
>>   llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
>> 
>> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=170088&r1=170087&r2=170088&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
>> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Wed Dec 12 21:00:38 2012
>> @@ -1836,7 +1836,8 @@
>>    Asm->OutStreamer.AddComment("DWARF version number");
>>    Asm->EmitInt16(dwarf::DWARF_VERSION);
>>    Asm->OutStreamer.AddComment("Offset Into Abbrev. Section");
>> -    Asm->EmitSectionOffset(Asm->GetTempSymbol("abbrev_begin"),
>> +    const MCSection *ASec = Asm->getObjFileLowering().getDwarfAbbrevSection();
>> +    Asm->EmitSectionOffset(Asm->GetTempSymbol(ASec->getLabelBeginName()),
>>                           DwarfAbbrevSectionSym);
>>    Asm->OutStreamer.AddComment("Address Size (in bytes)");
>>    Asm->EmitInt8(Asm->getDataLayout().getPointerSize());
>> @@ -1860,10 +1861,11 @@
>>  // Check to see if it is worth the effort.
>>  if (!Abbreviations.empty()) {
>>    // Start the debug abbrev section.
>> -    Asm->OutStreamer.SwitchSection(
>> -                            Asm->getObjFileLowering().getDwarfAbbrevSection());
>> +    const MCSection *ASec = Asm->getObjFileLowering().getDwarfAbbrevSection();
>> +    Asm->OutStreamer.SwitchSection(ASec);
>> 
>> -    Asm->OutStreamer.EmitLabel(Asm->GetTempSymbol("abbrev_begin"));
>> +    MCSymbol *Begin = Asm->GetTempSymbol(ASec->getLabelBeginName());
>> +    Asm->OutStreamer.EmitLabel(Begin);
>> 
>>    // For each abbrevation.
>>    for (unsigned i = 0, N = Abbreviations.size(); i < N; ++i) {
>> @@ -1880,7 +1882,8 @@
>>    // Mark end of abbreviations.
>>    Asm->EmitULEB128(0, "EOM(3)");
>> 
>> -    Asm->OutStreamer.EmitLabel(Asm->GetTempSymbol("abbrev_end"));
>> +    MCSymbol *End = Asm->GetTempSymbol(ASec->getLabelEndName());
>> +    Asm->OutStreamer.EmitLabel(End);
>>  }
>> }
>> 
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>