[llvm-commits] [llvm] r169791 - in /llvm/trunk: include/llvm/Target/ lib/CodeGen/SelectionDAG/ lib/Target/ARM/ lib/Target/Mips/ lib/Target/X86/ test/CodeGen/ARM/ test/CodeGen/X86/

[Chris Lattner]

On Dec 10, 2012, at 10:38 PM, Evan Cheng <evan.cheng at apple.com> wrote:

> 
> 
> On Dec 10, 2012, at 9:52 PM, Anton Korobeynikov <anton at korobeynikov.info> wrote:
> 
>>> -  virtual bool allowsUnalignedMemoryAccesses(EVT) const {
>>> +  virtual bool allowsUnalignedMemoryAccesses(EVT, bool *Fast = 0) const {
>> Can we just return, say std::pair<bool, bool> here? :)
> 
> I chose the change to avoid breaking out of tree targets. 

We'd prefer to keep LLVM APIs clean.  If the right thing is to break out of tree targets, the owner of those has to update them.  I don't have an opinion one way or the other about this particular change, but it's not a good reason :)

-Chris