[llvm-commits] [llvm] r170031 - /llvm/trunk/include/llvm/Support/YAMLTraits.h

[Benjamin Kramer]

On 12.12.2012, at 23:03, Nick Kledzik <kledzik at apple.com> wrote:

> Author: kledzik
> Date: Wed Dec 12 16:03:57 2012
> New Revision: 170031
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=170031&view=rev
> Log:
> AlignedCharArrayUnion is erroring with non-clang compilers
> 
> Modified:
>    llvm/trunk/include/llvm/Support/YAMLTraits.h
> 
> Modified: llvm/trunk/include/llvm/Support/YAMLTraits.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/YAMLTraits.h?rev=170031&r1=170030&r2=170031&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/Support/YAMLTraits.h (original)
> +++ llvm/trunk/include/llvm/Support/YAMLTraits.h Wed Dec 12 16:03:57 2012
> @@ -630,9 +630,9 @@
>   TNorm* operator->() { return BufPtr; }
> 
> private:
> -  typedef typename llvm::AlignedCharArrayUnion<TNorm> Storage;
> -
> -  Storage       Buffer;
> +  //typedef typename llvm::AlignedCharArrayUnion<TNorm> Storage;
> +  //Storage       Buffer;
> +  char          Buffer[sizeof(TNorm)];

How about just removing the "typename" specifier? I don't think it's necessary here. GCC eats that.

- Ben

>   IO           &io;
>   TNorm        *BufPtr;
>   TFinal       &Result;
> @@ -666,9 +666,9 @@
>   TNorm* operator->() { return BufPtr; }
> 
> private:
> -  typedef typename llvm::AlignedCharArrayUnion<TNorm> Storage;
> -
> -  Storage       Buffer;
> +  //typedef typename llvm::AlignedCharArrayUnion<TNorm> Storage;
> +  //Storage       Buffer;
> +  char          Buffer[sizeof(TNorm)];
>   IO           &io;
>   TNorm        *BufPtr;
>   TFinal       &Result;
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits