[llvm-commits] [PATCH] YAML I/O for review
Michael Spencer
bigcheesegs at gmail.com
Wed Dec 12 11:27:21 PST 2012
On Tue, Dec 11, 2012 at 4:36 PM, Nick Kledzik <kledzik at apple.com> wrote:
> I've updated the patch with the last review feedback. Enclosed is the patch and documentation:
>
>
>
>
>
> The changes since the last patch are:
> * Add explicit trait for sequences and document lists (std::vector no longer implicitly a sequence)
> * Remove all tabs
> * Uppercase local variable names
>
> Michael, can you try building this with Visual Studio to verify the traits work with that compiler. Thanks.
>
> -Nick
>
>
Builds and tests pass.
I have a few minor nits, but they can be resolved post commit. (Except
the trailing whitespace. Remove that before commit)
- Michael Spencer
More information about the llvm-commits
mailing list