[llvm-commits] [PATCH][FastMath, InstCombine] Fadd/Fsub optimizations

Duncan Sands baldrick at free.fr
Wed Dec 12 08:34:28 PST 2012


Hi Shuxin,

 >> My high-level concern with this patch is basically that this is a lot
>> of code, the algorithm is complex, and the implementation is hard to
>> reason about; I'm trying to find places where can simplify if
>> possible.  And I'm immediately skeptical of any performance claim
>> without numbers.
> Some 700 lines of code is nothing.
> Among them 650 lines are about utility, the core has about 50 lines.

I didn't read your patch but I have complete confidence in Eli's judgement, and
I think you should take whatever he says very seriously too.  If he says that
your patch seems too complex please consider the possibility that he is right,
and work hard to simplify, refactorize and clarify the code.

Ciao, Duncan.



More information about the llvm-commits mailing list