[llvm-commits] [PATCH] Fix typos in FileCheck comments

NAKAMURA Takumi geek4civic at gmail.com
Wed Dec 12 05:39:09 PST 2012


Applied in r169978! (and tweaked the test in r169977)

...Takumi

2012/12/12 Dmitri Gribenko <gribozavr at gmail.com>:
> On Thu, Dec 6, 2012 at 11:27 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>> On Thu, Dec 6, 2012 at 11:19 PM, Alexander Zinenko <ftynse at gmail.com> wrote:
>>> Thanks, Eli!
>>>
>>> Could you or someone else commit it, since I have no commit access?
>>>
>>>
>>> On 6 December 2012 20:59, Eli Bendersky <eliben at google.com> wrote:
>>>>
>>>> lgtm
>>>>
>>>> On Thu, Dec 6, 2012 at 10:50 AM, Alexander Zinenko <ftynse at gmail.com>
>>>> > Index: test/CodeGen/X86/atom-bypass-slow-division.ll
>>>> > ===================================================================
>>>> > --- test/CodeGen/X86/atom-bypass-slow-division.ll (revision 169521)
>>>> > +++ test/CodeGen/X86/atom-bypass-slow-division.ll (working copy)
>>>> > @@ -35,7 +35,7 @@
>>>> >  ; CHECK: divb
>>>> >  ; CHECK: addl
>>>> >  ; CHECK: ret
>>>> > -; CEECK-NOT: idivl
>>>> > +; CHECK-NOT: idivl
>>>> >  ; CHECK-NOT: divb
>>>> >    %resultdiv = sdiv i32 %a, %b
>>>> >    %resultrem = srem i32 %a, %b
>>>> > @@ -66,7 +66,7 @@
>>>> >
>>>> >  define i32 @test_use_div_reg_imm(i32 %a) nounwind {
>>>> >  ; CHECK: test_use_div_reg_imm
>>>> > -; CEHCK-NOT: test
>>>> > +; CHECK-NOT: test
>>>> >  ; CHECK-NOT: idiv
>>>> >  ; CHECK-NOT: divb
>>>> >    %resultdiv = sdiv i32 %a, 33
>>>> > @@ -75,7 +75,7 @@
>>>> >
>>>> >  define i32 @test_use_rem_reg_imm(i32 %a) nounwind {
>>>> >  ; CHECK: test_use_rem_reg_imm
>>>> > -; CEHCK-NOT: test
>>>> > +; CHECK-NOT: test
>>>> >  ; CHECK-NOT: idiv
>>>> >  ; CHECK-NOT: divb
>>>> >    %resultrem = srem i32 %a, 33
>>>> > @@ -84,7 +84,7 @@
>>>> >
>>>> >  define i32 @test_use_divrem_reg_imm(i32 %a) nounwind {
>>>> >  ; CHECK: test_use_divrem_reg_imm
>>>> > -; CEHCK-NOT: test
>>>> > +; CHECK-NOT: test
>>>> >  ; CHECK-NOT: idiv
>>>> >  ; CHECK-NOT: divb
>>>> >    %resultdiv = sdiv i32 %a, 33
>>
>> This one actually fails after the fix.  Committed the rest in r169547.
>>
>> Preston: could you please take a look at these typos in
>> test/CodeGen/X86/atom-bypass-slow-division.ll?
>
> Ping?
>
> Dmitri
>
> --
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list