[llvm-commits] [compiler-rt] r169736 - /compiler-rt/trunk/lib/asan/asan_interceptors.cc

[Alexander Potapenko]

In progress. This code is only executed when -asan-memintrin is off.

On Mon, Dec 10, 2012 at 8:17 PM, Kostya Serebryany <kcc at google.com> wrote:
> test?
>
>
> On Mon, Dec 10, 2012 at 8:02 PM, Alexander Potapenko <glider at google.com>
> wrote:
>>
>> Author: glider
>> Date: Mon Dec 10 10:02:13 2012
>> New Revision: 169736
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=169736&view=rev
>> Log:
>> [ASan] Typo fix in memcpy() and memmove() interceptors: ASAN_WRITE_RANGE
>> and ASAN_READ_RANGE were swapped.
>> This has been spotted by Anna Zaks (ganna at apple.com)
>>
>> Modified:
>>     compiler-rt/trunk/lib/asan/asan_interceptors.cc
>>
>> Modified: compiler-rt/trunk/lib/asan/asan_interceptors.cc
>> URL:
>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_interceptors.cc?rev=169736&r1=169735&r2=169736&view=diff
>>
>> ==============================================================================
>> --- compiler-rt/trunk/lib/asan/asan_interceptors.cc (original)
>> +++ compiler-rt/trunk/lib/asan/asan_interceptors.cc Mon Dec 10 10:02:13
>> 2012
>> @@ -277,8 +277,8 @@
>>        // See http://llvm.org/bugs/show_bug.cgi?id=11763.
>>        CHECK_RANGES_OVERLAP("memcpy", to, size, from, size);
>>      }
>> -    ASAN_WRITE_RANGE(from, size);
>> -    ASAN_READ_RANGE(to, size);
>> +    ASAN_READ_RANGE(from, size);
>> +    ASAN_WRITE_RANGE(to, size);
>>    }
>>  #if MAC_INTERPOSE_FUNCTIONS
>>    // Interposing of resolver functions is broken on Mac OS 10.7 and 10.8.
>> @@ -296,8 +296,8 @@
>>    }
>>    ENSURE_ASAN_INITED();
>>    if (flags()->replace_intrin) {
>> -    ASAN_WRITE_RANGE(from, size);
>> -    ASAN_READ_RANGE(to, size);
>> +    ASAN_READ_RANGE(from, size);
>> +    ASAN_WRITE_RANGE(to, size);
>>    }
>>  #if MAC_INTERPOSE_FUNCTIONS
>>    // Interposing of resolver functions is broken on Mac OS 10.7 and 10.8.
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow