[llvm-commits] [zorg] r169769 - /zorg/trunk/zorg/buildbot/commands/StandardizedTest.py

[David Blaikie]

Author: dblaikie
Date: Mon Dec 10 15:16:35 2012
New Revision: 169769

URL: http://llvm.org/viewvc/llvm-project?rev=169769&view=rev
Log:
Don't put log lines in a set.

This means that fail/pass counts won't be artificially lower. Instead they
should reflect the exact counts from the dg.sum summary with the caveat that
all failure types are grouped under the failure count and all pass types
(including xfail) are counted under the pass count. I'll address this soon.

Modified:
    zorg/trunk/zorg/buildbot/commands/StandardizedTest.py

Modified: zorg/trunk/zorg/buildbot/commands/StandardizedTest.py
URL: http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/commands/StandardizedTest.py?rev=169769&r1=169768&r2=169769&view=diff
==============================================================================
--- zorg/trunk/zorg/buildbot/commands/StandardizedTest.py (original)
+++ zorg/trunk/zorg/buildbot/commands/StandardizedTest.py Mon Dec 10 15:16:35 2012
@@ -54,10 +54,7 @@
                 hasIgnored = True
                 
 
-            if result not in results_by_code:
-                results_by_code[result] = set()
-
-            results_by_code[result].add(test)
+            results_by_code.setdefault(result, []).append(test)
 
             # Add logs for failures.
             if result in self.failingCodes and len(logs) < self.maxLogs:
@@ -77,7 +74,8 @@
         for code in self.warningCodes:
             results = results_by_code.get(code)
             if results:
-                results_by_code[code] -= ignored_failures
+                results_by_code[code] = [x for x in results_by_code[code]
+                                         if x not in ignored_failures]
 
         # Summarize result counts.
         total = failed = passed = warnings = 0
@@ -97,7 +95,6 @@
             # Add a list of the tests in each category, for everything except
             # PASS.
             if code != 'PASS':
-                results = list(results)
                 results.sort()
                 self.addCompleteLog('tests.%s' % code,
                                     '\n'.join(results) + '\n')