[llvm-commits] [llvm] r162219 - in /llvm/trunk: CMakeLists.txt cmake/config-ix.cmake

[Sebastian Pop]

NAKAMURA Takumi wrote:
> Sebastian, excuse me to ping an old commit.
> 
> Why did you need to make but also "TARGET_TRIPLE" configurable, not
> only "LLVM_DEFAULT_TARGET_TRIPLE"?
> 
> I think "TARGET_TRIPLE" may be an alias of LLVM_DEFAULT_TARGET_TRIPLE.
> (or, TARGET_TRIPLE might be localized as possible)
> I'll update it if it did not break yours.
> 
> ...Takumi
> 
> --- a/llvm/CMakeLists.txt
> +++ b/llvm/CMakeLists.txt
> @@ -242,8 +242,7 @@ include(config-ix)
>  # invocation time.
>  set(LLVM_DEFAULT_TARGET_TRIPLE "${LLVM_HOST_TRIPLE}" CACHE STRING
>    "Default target for which LLVM will generate code." )
> -set(TARGET_TRIPLE "${LLVM_DEFAULT_TARGET_TRIPLE}" CACHE STRING
> -  "Default target for which LLVM will generate code." )
> +set(TARGET_TRIPLE "${LLVM_DEFAULT_TARGET_TRIPLE}")
> 

LGTM.  It does not make sense to have different values for TARGET_TRIPLE and
LLVM_DEFAULT_TARGET_TRIPLE, so I think it is ok to make TARGET_TRIPLE an alias.

Thanks,
Sebastian

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation