[llvm-commits] [PATCH] Convert GarbageCollection.html to reST

Alexander Zinenko ftynse at gmail.com
Sun Dec 9 07:27:53 PST 2012


Hi Sean!

How could I overlook that that sentence...

Please find the updated patch attached with everything fixed.
There is also some trailing whitespace in docs/subsystems.rst in the parts
not related to the current document.  Maybe someone should remove it as
well.


On 9 December 2012 17:01, Sean Silva <silvas at purdue.edu> wrote:

> You have lost part of the sentence:
>
> "for each function your compiler emits. Since the shadow stack is
> built into LLVM, you do not need to load a plugin."
>
> Also please get rid of trailing whitespace and move the definitions of
> |v| and |x| to be next to the table where they are used.
>
> -- Sean Silva
>
> On Sun, Dec 9, 2012 at 9:16 AM, Alexander Zinenko <ftynse at gmail.com>
> wrote:
> > Here is the GarbageCollection.rst document converted from original HTML.
> > It contains a table which occupies more than 80 columns in the textual
> > representation but this makes it more readable as for me.
> >
> > Review and commit, please!
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121209/9cd39964/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: doc-gc.patch
Type: application/octet-stream
Size: 92201 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121209/9cd39964/attachment.obj>


More information about the llvm-commits mailing list