[llvm-commits] [PATCH] Adding the Linpack test to the test suite

Duncan Sands baldrick at free.fr
Sat Dec 8 11:43:21 PST 2012


Hi Renato,

On 08/12/12 20:36, Renato Golin wrote:
> On 8 December 2012 14:25, Duncan Sands <baldrick at free.fr> wrote:
>> not sure what flags you mean.  The testsuite does a pretty thorough kind of
>> link time optimization on all tests, it's not at all the same thing as
>> "clang -O3" for example.  It's just the way the testsuite works.
>
> I meant "globalopt" or "internalize", the ones you say are breaking the build.
>
> I don't understand why I don't get this on my local installation, I'm
> guessing it's how I set up the run script.
>
> If this is causing so much trouble, I think it's worth keep it
> disabled for now, and we go one by one, enabling when they're well
> behaved. But I didn't want to completely remove them, since it's a
> nice way to locally test codegen and vectorization.
>
> If I just remove it from the Makefile on Benchmarks, will it just
> ignore? Or are we going to get errors "directory found but not in
> test"?

I think the correct approach is to reduce a small testcase and open a bug report
about it [*].  Given that (eg) LivermoreLoops broke all three fnt bots at
lab.llvm.org I think we should just revert the patch that added this benchmark
until it is sorted out.

Ciao, Duncan.

[*] I plan to work on this after the 3.2 release.



More information about the llvm-commits mailing list