[llvm-commits] PATCH: Enable scalar store promotion in DAG Legalizer

Duncan Sands baldrick at free.fr
Fri Dec 7 21:06:22 PST 2012


Hi Tom, LGTM.

Best wishes, Duncan.

On 07/12/12 23:20, Tom Stellard wrote:
> On Fri, Dec 07, 2012 at 06:49:35PM +0100, Duncan Sands wrote:
>> Hi Tom,
>>
>>> The attached patch removes an assert that prevents the DAG Legalizer
>> >from promoting scalar stores.  I'm not sure why this assert is here,
>>> but it seems safe to remove.
>>
>> can you please add an assertion that the old and new types have the same
>> number of bits.  Otherwise it seems OK to me.
>>
>
> Hi Ducan,
>
> Thanks for the review, here are the updated patches.
>
> -Tom
>




More information about the llvm-commits mailing list