[llvm-commits] PATCH: refactoring MCInstFragment and MCDataFragment

Eli Bendersky eliben at google.com
Fri Dec 7 14:09:35 PST 2012


>> Most users of SmallString probably just use StringRef or something like that for access. I agree that SmallVector is more appropriate for this code anyway, so a follow-up sounds great.
>>

Since the follow-up turned out to be pretty straightforward, I just
went ahead and committed it in 169644. So MCInstFragment is back to
240 bytes and the interface is cleaner (no explicit size). Coming to
think of it, all the other fragments could probably benefit from a
SmallString --> SmallVector conversion as well.

Let me know if you see any problem with this.

Eli



More information about the llvm-commits mailing list