[llvm-commits] [llvm] r169568 - /llvm/trunk/utils/unittest/googletest/Makefile

[Alexey Samsonov]

Thank you (and sorry for the breakage)!

I looked at Makefile.common which has lines:
# 4. Source - If specified, this sets the source code filenames.  If this
#    is not set, it defaults to be all of the .cpp, .c, .y, and .l files
#    in the current directory.

Should we s/Source/SOURCES here?

On Thu, Dec 6, 2012 at 5:25 PM, NAKAMURA Takumi <geek4civic at gmail.com>wrote:

> Author: chapuni
> Date: Thu Dec  6 19:25:45 2012
> New Revision: 169568
>
> URL: http://llvm.org/viewvc/llvm-project?rev=169568&view=rev
> Log:
> unittest/googletest/Makefile: Unbreak out-of-tree build.
>
>   - Use SOURCES instead of Source. See Makefile.rules and
> MakefileGuide.html.
>   - Don't assume the current directory. $(wildcard *.cc) doesn't match
> anything on corresponding build directory.
>
> Modified:
>     llvm/trunk/utils/unittest/googletest/Makefile
>
> Modified: llvm/trunk/utils/unittest/googletest/Makefile
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/unittest/googletest/Makefile?rev=169568&r1=169567&r2=169568&view=diff
>
> ==============================================================================
> --- llvm/trunk/utils/unittest/googletest/Makefile (original)
> +++ llvm/trunk/utils/unittest/googletest/Makefile Thu Dec  6 19:25:45 2012
> @@ -36,6 +36,6 @@
>
>  NO_INSTALL = 1
>
> -Source = $(filter-out gtest-all.cc,$(wildcard *.cc))
> +SOURCES = $(filter-out gtest-all.cc, $(notdir $(wildcard
> $(PROJ_SRC_DIR)/*.cc)))
>
>  include $(LEVEL)/Makefile.common
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121206/ebf27849/attachment.html>