[llvm-commits] [PATCH] Add gtest-all.cc to LLVM copy of googletest. Make LLVMSupport unpluggable from it.

[Chandler Carruth]

================
Comment at: utils/unittest/googletest/include/gtest/internal/gtest-internal.h:59-61
@@ -58,1 +58,5 @@
 
+#ifndef GTEST_USES_LLVM_RAW_OSTREAM
+# define GTEST_USES_LLVM_RAW_OSTREAM 1
+#endif
+#if GTEST_USES_LLVM_RAW_OSTREAM
----------------
Do we really need these? It would seem cleaner to avoid this.

I think you can do:

#if !GTEST_NO_LLVM_RAW_OSTREAM
...
#endif

Then when this macro is not #defined, it will expand to 0, and thus the condition will be true.


http://llvm-reviews.chandlerc.com/D187