[llvm-commits] [PATCH] Remove readonly/readnone attributes from all called functions

Kostya Serebryany kcc at google.com
Thu Dec 6 02:25:36 PST 2012


  >> we can clear the attributes in MemorySanitizer.doInitialization for all functions in a module. How does this sound?
  That sounds nicer, if it works. ALso, add asserts to check that no one has set these attributes back

  >> I'm also not entirely convinced that removing readonly attribute is a safe operation in itself. There could have been optimization already applied to the function's callers that rely on the fact that the function is readonly.
  I can't imagine such situation. readonly/readnone is an optimistic information. If we don't have it, we simply can't do something.

http://llvm-reviews.chandlerc.com/D173



More information about the llvm-commits mailing list