[llvm-commits] [PATCH: polly] Integrate polly test-suite into 'make check-all'

[Andy Gibbs]

On Wednesday, December 05, 2012 7:33 PM, Tobias Grosser wrote:
> On 12/05/2012 06:42 PM, Sebastian Pop wrote:
>> Andy Gibbs wrote:
>>> Hi,
>>>
>>> Attached is a patch to polly's test-suite to integrate it into
>>> llvm's "make check-all" when polly is built as part of the whole.
>>> I've also added a "make check-polly" to match the general "make
>>> check-*" idiom used by other projects.  This links to the same
>>> behaviour as "make polly-test", which remains available.  Also, when
>>> building outside llvm's folder structure, the test-suite can be
>>> invoked as before.
>>>
>>> Are people happy for me to commit this change?
>>
>> LGTM.  Befor you commit, please wait for Tobi to comment on this change 
>> as well.
>
> Great. I was thinking about doing this myself. Great you have been faster.
>
> The patch itself looks good. So please go ahead and commit.

Thanks for the review; committed at r169487.

>> I see that you are modifying only the cmake part: the same problems exist 
>> also
>> in configure + make.
>
> Yes, if you manage to update autoconf as well that would be great.

I agree it would be good to do this, but I'm not too familiar with how the 
llvm
makefiles work, in particular how it "picks up" sub-project test-suites into 
a
"make check-all".  I can take a look in a couple of days time.

Cheers
Andy