[llvm-commits] [PATCH] lld driver

[Sean Silva]

================
Comment at: include/lld/Core/ErrorOr.h:10-12
@@ +9,5 @@
+///
+/// \file
+///
+/// Provides ErrorOr<T> smart pointer.
+///
----------------
Michael Spencer wrote:
> Sean Silva wrote:
> > Since this class seems generally useful, it is probably worth mentioning here why this file is not in libSupport.
> It's c++11. Although it's still useful for reference and value types without c++11.
Is there any current usage in this code that would not be possible if this were located in libSupport? I think it would be really beneficial to have this more generally available. "reference and value types" seems like a pretty large class of objects that this could be useful for.

Also, I'm not sure if this was understood from what I said, but I think that the reason should be explicitly mentioned in this header comment (if it isn't integrated into libSupport, that is).


http://llvm-reviews.chandlerc.com/D169