[llvm-commits] NVPTX: Handle struct literal arguments without crashing

[Justin Holewinski]

Committed in r169418.  Sorry for the delay!


On Fri, Nov 30, 2012 at 3:33 PM, Eric Holk <eholk at cs.indiana.edu> wrote:

> Here is an updated version of my patch with a test case.
>
> Thanks,
> Eric
>
>
> On Wed, Nov 28, 2012 at 10:02 AM, Justin Holewinski <
> justin.holewinski at gmail.com> wrote:
>
>> The change itself looks fine, but please do add a test case.
>>
>> Do you have commit access?
>>
>>
>> On Wed, Nov 28, 2012 at 12:10 AM, Meador Inge <meadori at codesourcery.com>wrote:
>>
>>>
>>> On Nov 27, 2012, at 12:28 PM, Eric Holk wrote:
>>>
>>> > I found that compiling functions using struct literals would trip an
>>> assert in StructType::getName. This patch checks that the struct isn't a
>>> literal struct before calling getName and allows it to generate code
>>> successfully.
>>> >
>>> > Let me know if there are questions, comments, or anything else needed
>>> from me.
>>>
>>> Please provide a test case.
>>>
>>> --
>>> Meador Inge
>>> CodeSourcery / Mentor Embedded
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>
>>
>>
>> --
>>
>> Thanks,
>>
>> Justin Holewinski
>>
>>
>


-- 

Thanks,

Justin Holewinski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121205/051be860/attachment.html>