[llvm-commits] [PATCH] Teach llvm-objdump to dump Win64 exception tables

[Michael Spencer]

On Tue, Dec 4, 2012 at 11:23 PM, Kai <kai at redstar.de> wrote:
> Hi Michael!
>
> Thanks for your review comments. The changed patches are attached. I hope I
> catched all missing spaces...
>
> Regards
> Kai

Committed as r169414 and r169415.

- Michael Spencer

>
>
> On 04.12.2012 20:43, Michael Spencer wrote:
>>
>> On Wed, Nov 28, 2012 at 12:00 AM, Kai <kai at redstar.de> wrote:
>>>
>>> Hi Sean,
>>>
>>> that's easy to fix. See attached patch.
>>>
>>> Regards
>>> Kai
>>
>>
>> This looks good. I'd like to see the following fixes:
>>
>> * Merge patch 1 and 2.
>> * Add spaces around operators. There are a bunch of blah+1.
>>
>>> @@ -666,7 +688,8 @@ int main(int argc, char **argv) {
>>>         && !Relocations
>>>         && !SectionHeaders
>>>         && !SectionContents
>>> -      && !SymbolTable) {
>>> +      && !SymbolTable
>>> +      && !::UnwindInfo) {
>>
>>
>> * Don't globally qualify names.
>>
>>>       cl::PrintHelpMessage();
>>>       return 2;
>>>     }
>>
>>
>> With those changes these two patches can be committed.
>>
>> - Michael Spencer
>>
>>>
>>>
>>> On 28.11.2012 04:53, Sean Silva wrote:
>>>>
>>>>
>>>> Looks pretty much good. Besides a few minor things I've mentioned
>>>> below, it looks good as far as I can tell. Michael, can you look this
>>>> over and give it a final review?
>>>>
>>>> +  /* The data after unwindCodes depends on flags.
>>>> +   * If UNW_ExceptionHandler or UNW_TerminateHandler is set then
>>>> follows
>>>> +   * the address of the language-specific exception handler.
>>>> +   * If UNW_ChainInfo is set then follows a RuntimeFunction which
>>>> defines
>>>> +   * the chained unwind info.
>>>> +   * For more information please see MSDN at:
>>>> +   * http://msdn.microsoft.com/en-us/library/ddssxxy8.aspx
>>>> +   */
>>>>
>>>> Use C++ comments for this (this is actually in the coding standards).
>>>>
>>>> +  /// getLanguageSpecificData - Return pointer to language specific
>>>> data
>>>> part
>>>> +  /// of UnwindInfo.
>>>>
>>>> Use \brief. Instead of duplicating the name.
>>>>
>>>>
>>>>
>>>> http://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments
>>>>
>>>> +      printCOFFSymbolAddress(outs(), Rels, SectionOffset +
>>>> +                              offsetof(RuntimeFunction, StartAddress),
>>>>
>>>> Please align these. the 'o' of "offsetof" should be under the 'o' of
>>>> "outs()".
>>>>
>>>> -- Sean Silva
>>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>