[llvm-commits] [llvm] r169218 - in /llvm/trunk: include/llvm/ lib/CodeGen/AsmPrinter/ lib/VMCore/ test/CodeGen/ARM/ test/CodeGen/Thumb/ test/CodeGen/X86/ test/DebugInfo/ test/DebugInfo/X86/ test/JitListener/

[Bill Wendling]

On Dec 5, 2012, at 11:29 AM, Eric Christopher <echristo at gmail.com> wrote:

> On Wed, Dec 5, 2012 at 11:25 AM, Bill Wendling <isanbard at gmail.com> wrote:
> On Dec 5, 2012, at 11:07 AM, Eric Christopher <echristo at gmail.com> wrote:
> 
> > > Awesome. FWIW we're probably getting those cases wrong in debug info :)
> > >
> > We're definitely getting the negative lower bounds wrong, since the value's retrieved as a uint64_t. The zero case will be omitted for Ada and friends.
> >
> > Agreed. If you'd like to fix it that'd be awesome, if not file a bug and I'll get to it eventually.
> >
> Okay. The fix is to emit the lower bound in all cases. I don't think this will be a problem for the debugger. It just adds extra information that it'll probably ignore in C/C++. :)
> 
> No, it's not. The correct is to omit it when the lower bound is the same as the default lower bound which I just gave in this thread :)
> 
Well, that presents a problem. We don't know a priori what the default lower bound is without seeing what the source language is. Do you want another field added to DISubrange that tells us what the default lower bound is? or maybe a boolean which indicates that the lower bound is the default or no?

-bw