[llvm-commits] [lld] r169306 - in /lld/trunk/lib: Core/CMakeLists.txt ReaderWriter/CMakeLists.txt ReaderWriter/ELF/CMakeLists.txt ReaderWriter/MachO/CMakeLists.txt ReaderWriter/Native/CMakeLists.txt ReaderWriter/PECOFF/CMakeLists.txt ReaderWriter/YAML/CMakeLists.txt

[Benjamin Kramer]

On 05.12.2012, at 01:20, Sean Silva <silvas at purdue.edu> wrote:

> How were these libraries building without this?

It works when everything is linked statically into a binary, but falls
apart if it only links parts of it or if each library is linked as a
separate shared object. I build debug builds as shared libraries
because it takes the linking bottleneck away, speeding up incremental
rebuilds.

- Ben
>
> -- Sean Silva
>
> On Tue, Dec 4, 2012 at 4:09 PM, Benjamin Kramer
> <benny.kra at googlemail.com> wrote:
>> Author: d0k
>> Date: Tue Dec  4 15:09:04 2012
>> New Revision: 169306
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=169306&view=rev
>> Log:
>> Add library dependencies to the lld cmake build.
>>
>> Modified:
>>    lld/trunk/lib/Core/CMakeLists.txt
>>    lld/trunk/lib/ReaderWriter/CMakeLists.txt
>>    lld/trunk/lib/ReaderWriter/ELF/CMakeLists.txt
>>    lld/trunk/lib/ReaderWriter/MachO/CMakeLists.txt
>>    lld/trunk/lib/ReaderWriter/Native/CMakeLists.txt
>>    lld/trunk/lib/ReaderWriter/PECOFF/CMakeLists.txt
>>    lld/trunk/lib/ReaderWriter/YAML/CMakeLists.txt
>>
>> Modified: lld/trunk/lib/Core/CMakeLists.txt
>> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/CMakeLists.txt?rev=169306&r1=169305&r2=169306&view=diff
>> ==============================================================================
>> --- lld/trunk/lib/Core/CMakeLists.txt (original)
>> +++ lld/trunk/lib/Core/CMakeLists.txt Tue Dec  4 15:09:04 2012
>> @@ -1,3 +1,5 @@
>> +set(LLVM_LINK_COMPONENTS support)
>> +
>> add_lld_library(lldCore
>>   Error.cpp
>>   File.cpp
>>
>> Modified: lld/trunk/lib/ReaderWriter/CMakeLists.txt
>> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/CMakeLists.txt?rev=169306&r1=169305&r2=169306&view=diff
>> ==============================================================================
>> --- lld/trunk/lib/ReaderWriter/CMakeLists.txt (original)
>> +++ lld/trunk/lib/ReaderWriter/CMakeLists.txt Tue Dec  4 15:09:04 2012
>> @@ -1,3 +1,5 @@
>> +set(LLVM_LINK_COMPONENTS object)
>> +
>> add_subdirectory(ELF)
>> add_subdirectory(MachO)
>> add_subdirectory(Native)
>> @@ -8,3 +10,7 @@
>>   Writer.cpp
>>   ReaderArchive.cpp
>>   )
>> +
>> +target_link_libraries(lldReaderWriter
>> +  lldCore
>> +  )
>>
>> Modified: lld/trunk/lib/ReaderWriter/ELF/CMakeLists.txt
>> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/CMakeLists.txt?rev=169306&r1=169305&r2=169306&view=diff
>> ==============================================================================
>> --- lld/trunk/lib/ReaderWriter/ELF/CMakeLists.txt (original)
>> +++ lld/trunk/lib/ReaderWriter/ELF/CMakeLists.txt Tue Dec  4 15:09:04 2012
>> @@ -7,3 +7,7 @@
>>   X86Reference.cpp
>>   WriterOptionsELF.cpp
>>   )
>> +
>> +target_link_libraries(lldELF
>> +  lldReaderWriter
>> +  )
>>
>> Modified: lld/trunk/lib/ReaderWriter/MachO/CMakeLists.txt
>> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/CMakeLists.txt?rev=169306&r1=169305&r2=169306&view=diff
>> ==============================================================================
>> --- lld/trunk/lib/ReaderWriter/MachO/CMakeLists.txt (original)
>> +++ lld/trunk/lib/ReaderWriter/MachO/CMakeLists.txt Tue Dec  4 15:09:04 2012
>> @@ -3,3 +3,8 @@
>>   WriterOptionsMachO.cpp
>>   ReferenceKinds.cpp
>>   )
>> +
>> +target_link_libraries(lldMachO
>> +  lldReaderWriter
>> +  lldPasses
>> +  )
>>
>> Modified: lld/trunk/lib/ReaderWriter/Native/CMakeLists.txt
>> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/Native/CMakeLists.txt?rev=169306&r1=169305&r2=169306&view=diff
>> ==============================================================================
>> --- lld/trunk/lib/ReaderWriter/Native/CMakeLists.txt (original)
>> +++ lld/trunk/lib/ReaderWriter/Native/CMakeLists.txt Tue Dec  4 15:09:04 2012
>> @@ -2,3 +2,7 @@
>>   ReaderNative.cpp
>>   WriterNative.cpp
>>   )
>> +
>> +target_link_libraries(lldNative
>> +  lldReaderWriter
>> +  )
>>
>> Modified: lld/trunk/lib/ReaderWriter/PECOFF/CMakeLists.txt
>> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/CMakeLists.txt?rev=169306&r1=169305&r2=169306&view=diff
>> ==============================================================================
>> --- lld/trunk/lib/ReaderWriter/PECOFF/CMakeLists.txt (original)
>> +++ lld/trunk/lib/ReaderWriter/PECOFF/CMakeLists.txt Tue Dec  4 15:09:04 2012
>> @@ -2,3 +2,7 @@
>>   ReaderCOFF.cpp
>>   WriterPECOFF.cpp
>>   )
>> +
>> +target_link_libraries(lldPECOFF
>> +  lldReaderWriter
>> +  )
>>
>> Modified: lld/trunk/lib/ReaderWriter/YAML/CMakeLists.txt
>> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/YAML/CMakeLists.txt?rev=169306&r1=169305&r2=169306&view=diff
>> ==============================================================================
>> --- lld/trunk/lib/ReaderWriter/YAML/CMakeLists.txt (original)
>> +++ lld/trunk/lib/ReaderWriter/YAML/CMakeLists.txt Tue Dec  4 15:09:04 2012
>> @@ -3,3 +3,7 @@
>>   ReaderYAML.cpp
>>   WriterYAML.cpp
>>   )
>> +
>> +target_link_libraries(lldYAML
>> +  lldReaderWriter
>> +  )
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits