[llvm-commits] Fixing Bug 13662: paired register for inline asm with 64-bit data on ARM

[Weiming Zhao]

Hi Jakob and Jim,

 

Do you have any suggestions or comments?

 

Thanks,

Weiming

 

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation

 

From: Evan Cheng [mailto:evan.cheng at apple.com] 
Sent: Thursday, November 29, 2012 11:58 AM
To: weimingz at codeaurora.org
Cc: 'Jakob Stoklund Olesen'; llvm-commits at cs.uiuc.edu; grosbach at apple.com
Subject: Re: [llvm-commits] Fixing Bug 13662: paired register for inline asm
with 64-bit data on ARM

 

LGTM

On Nov 28, 2012, at 9:50 AM, Weiming Zhao <weimingz at codeaurora.org> wrote:





Ping .

 

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation

 

From: Weiming Zhao [mailto:weimingz@ <http://codeaurora.org> codeaurora.org]

Sent: Monday, November 19, 2012 3:13 PM
To: 'Jakob Stoklund Olesen'; ' <mailto:llvm-commits at cs.uiuc.edu>
llvm-commits at cs.uiuc.edu'; ' <mailto:grosbach at apple.com> grosbach at apple.com'
Subject: Fixing Bug 13662: paired register for inline asm with 64-bit data
on ARM

 

Hi Jakob & Jim,

 

Sorry for keep you busy, but here is the last part of my patches. :D

It enables inline asm of ldrexd/strexd to work correctly.

 

I have to change CodeGen/SelectionDAG/InstrEmitter.cpp a litte bit because:
for the inline asm nodes, I have to put a virtual reg instead of a value
node.

And due to "untyped" type, I can't insert CopyFromReg or CopyToReg as the
framework won't find the GPRPairReg class.

So I have to directly connect ExtractSubReg, RegSequence with a Register
SDNode.

 

Please help to review it.

 

Thanks,

Weiming

 

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation

 

_______________________________________________
llvm-commits mailing list
 <mailto:llvm-commits at cs.uiuc.edu> llvm-commits at cs.uiuc.edu
 <http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121204/c684ca12/attachment.html>