[llvm-commits] [llvm] r169214 - in /llvm/trunk: include/llvm/Transforms/IPO/InlinerPass.h lib/Transforms/IPO/InlineAlways.cpp lib/Transforms/IPO/InlineSimple.cpp lib/Transforms/Scalar/LICM.cpp unittests/VMCore/PassManagerTest.cpp

[Matt Beaumont-Gay]

On Mon, Dec 3, 2012 at 11:34 PM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> 2012/12/4 Matt Beaumont-Gay <matthewbg at google.com>:
>> Author: matthewbg
>> Date: Mon Dec  3 23:41:27 2012
>> New Revision: 169214
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=169214&view=rev
>> Log:
>> Add 'using' declarations to suppress -Woverloaded-virtual warnings.
>
>> Modified: llvm/trunk/unittests/VMCore/PassManagerTest.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/VMCore/PassManagerTest.cpp?rev=169214&r1=169213&r2=169214&view=diff
>> ==============================================================================
>> --- llvm/trunk/unittests/VMCore/PassManagerTest.cpp (original)
>> +++ llvm/trunk/unittests/VMCore/PassManagerTest.cpp Mon Dec  3 23:41:27 2012
>> @@ -148,6 +148,8 @@
>>      template<typename T, typename P>
>>      struct PassTest : public PassTestBase<P> {
>>      public:
>> +      using llvm::Pass::doInitialization;
>> +      using llvm::Pass::doFinalization;
>
> MSVC(10) complained "using" in a class template. Tweaked in r169225.
>
> C2602: 'llvm::Pass::doInitialization' is not a member of a base class
> of 'llvm::`anonymous-namespace'::PassTest<T,P>'

Thanks! We'll make all of the compilers happy eventually...

>
> I haven't checked it on msvc11.
>
> ...Takumi
>
>>        virtual bool doInitialization(T &t) {
>>          EXPECT_FALSE(PassTestBase<P>::initialized);
>>          PassTestBase<P>::initialized = true;