[llvm-commits] [PATCH] AddressSanitizer: runtime support for use-after-scope bugs.

Alexey Samsonov samsonov at google.com
Mon Dec 3 17:39:48 PST 2012


r169201

On Sat, Dec 1, 2012 at 9:46 AM, Kostya Serebryany <kcc at google.com> wrote:

>
>   LGTM
>
>
> ================
> Comment at: lib/asan/lit_tests/use-after-scope-inlined.cc:1
> @@ +1,2 @@
> +// Test with "-O2" only to make sure inlining (leading to use-after-scope)
> +// happens. "always_inline" is not enough, as Clang doesn't emit
> ----------------
> Alexey Samsonov wrote:
> > Kostya Serebryany wrote:
> > > use-after-scope feature deserves a more extensive set test,
> > > probably in form of large list of DEATH_TESTS (like in asan_test.cc)
> > > in a separate file, asan_lifetime_test.cc
> > > That could go as a separate commit.
> > I agree that I should better start writing these tests :) Anyway, they
> should go in when we teach Clang to emit lifetime markers to catch actual
> use-after-scope bugs.
> Cases with inlining seem to work fine today. Why wait?
>
>
> http://llvm-reviews.chandlerc.com/D141
>



-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121203/8d7a115e/attachment.html>


More information about the llvm-commits mailing list