[llvm-commits] RFC moving doInitialization/doFinalization to Pass class
Evan Cheng
evan.cheng at apple.com
Mon Dec 3 10:02:39 PST 2012
LGTM
Evan
On Dec 3, 2012, at 9:59 AM, Pedro Artigas <partigas at apple.com> wrote:
> Hello All,
>
> No comments? I am guessing everybody is ok with the change them!
>
> Thanks
>
> Pedro
>
> On Nov 30, 2012, at 4:13 PM, Pedro Artigas <partigas at apple.com> wrote:
>
>> Hello All,
>>
>> The patch below moves doInitialization(Module&) and doFinalization(Module&) to the Pass class (from Module/Function/Etc…), due to name clashes several using directives are needed to make it work. Since using the "using" keyword may be considered bad style I wanted to know what people think and if anyone can think of an alternative.
>>
>> <patch.txt>
>>
>> Thanks
>>
>> Pedro
>>
>> PS: It also removes some unreachable code BTW
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
More information about the llvm-commits
mailing list