[llvm-commits] [compiler-rt] r169118 - in /compiler-rt/trunk/lib/asan/tests: asan_noinst_test.cc asan_test.cc asan_test_config.h asan_test_utils.h

[Dmitri Gribenko]

On Mon, Dec 3, 2012 at 11:43 AM, Kostya Serebryany <kcc at google.com> wrote:
> Modified: compiler-rt/trunk/lib/asan/tests/asan_test_utils.h
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/tests/asan_test_utils.h?rev=169118&r1=169117&r2=169118&view=diff
> ==============================================================================
> --- compiler-rt/trunk/lib/asan/tests/asan_test_utils.h (original)
> +++ compiler-rt/trunk/lib/asan/tests/asan_test_utils.h Mon Dec  3 03:43:56 2012
> @@ -68,4 +68,8 @@
>    return ret;
>  }
>
> +// Check that pthread_create/pthread_join return success.
> +#define PTHREAD_CREATE(a, b, c, d) EXPECT_EQ(0, pthread_create(a, b, c, d))
> +#define PTHREAD_JOIN(a, b) EXPECT_EQ(0, pthread_join(a, b))
> +
>  #endif  // ASAN_TEST_UTILS_H

Hello Kostya,

I think you could use ASSERT_EQ here, since it does not make sense to
continue if pthread_* fails.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/