[llvm-commits] MachOObjectFile::getSectionName

[Rafael Espíndola]

CCing Patrick who wrote the original patch.

On 1 December 2012 22:27, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> I was trying to get EH working with the MCJIT on darwin, but my code
> was failing to find the EH section. Turns out that the problem was
> that in MachOObjectFile::getSectionName we have
>
>  static char result[34];
>  ...
>  Result = StringRef(result);
>
> And the code in MCJIT stores that StringRef. I assume the bug is in
> MachOObjectFile::getSectionName, not in MCJIT. If I remember
> correctly, one of the objectives of the Object library was to point
> directly into the mapped buffer with the object file in it. If that is
> the case, shouldn't MachOObjectFile::getSectionName return just
> Sect->Name and have another function for getting the
> Sect->SegmentName?
>
> Cheers,
> Rafael