[llvm-commits] NVPTX: Handle struct literal arguments without crashing

[Eric Holk]

Here is an updated version of my patch with a test case.

Thanks,
Eric


On Wed, Nov 28, 2012 at 10:02 AM, Justin Holewinski <
justin.holewinski at gmail.com> wrote:

> The change itself looks fine, but please do add a test case.
>
> Do you have commit access?
>
>
> On Wed, Nov 28, 2012 at 12:10 AM, Meador Inge <meadori at codesourcery.com>wrote:
>
>>
>> On Nov 27, 2012, at 12:28 PM, Eric Holk wrote:
>>
>> > I found that compiling functions using struct literals would trip an
>> assert in StructType::getName. This patch checks that the struct isn't a
>> literal struct before calling getName and allows it to generate code
>> successfully.
>> >
>> > Let me know if there are questions, comments, or anything else needed
>> from me.
>>
>> Please provide a test case.
>>
>> --
>> Meador Inge
>> CodeSourcery / Mentor Embedded
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
>
> --
>
> Thanks,
>
> Justin Holewinski
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121130/7e874781/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nvptx-struct-literal.patch
Type: application/octet-stream
Size: 959 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121130/7e874781/attachment.obj>