[llvm-commits] [PATCH] Move function prototype attribute inference to instcombine

[Owen Anderson]

On Nov 29, 2012, at 10:16 PM, Duncan Sands <baldrick at free.fr> wrote:

> Hi Meador,
> 
> On 30/11/12 06:22, Meador Inge wrote:
>> The simplify-libcalls pass implemented a doInitialization hook to infer
>> function prototype attributes for well-known functions.  Now that library
>> call simplification is being carried out in instcombine it makes sense to
>> move the attribute inference there as well.
> 
> I'm not a big fan of doInitialization personally.  Couldn't you do it lazily
> the first time that they are needed instead?

Indeed, Pedro has been working with the ASAN/TSAN guys to clean up and remove this kind of behavior in doInitialization on their passes.

--Owen