[llvm-commits] [llvm] r168711 - in /llvm/trunk: lib/Analysis/ScalarEvolution.cpp test/Transforms/IndVarSimplify/eliminate-comparison.ll

[Pawel Wodnicki]

> 
> On Nov 29, 2012, at 5:48 PM, Chris Lattner <clattner at apple.com> wrote:
> 
>>
>> On Nov 29, 2012, at 11:04 AM, Benjamin Kramer <benny.kra at gmail.com> wrote:
>>>>
>>>> Hi Ben,
>>>>
>>>> Thanks for the fix. But why didn't you go for the more obvious fix?
>>>>
>>>> -      return CmpInst::isFalseWhenEqual(Pred);
>>>> +      return CmpInst::isFalseWhenEqual(FoundPred);
>>>>
>>>
>>> The original patch is still safe for 3.2, it only misses a potential optimization.
>>
>> I'd prefer to have Andy approve whichever patch makes the most sense for 3.2.  Andy, what do you think?
>>
>> -Chris
> 
> 
> They're both reasonable, but let's pull in the second, simpler fix for more consistency across branches. (it may optimize something new, but even more likely something was accidentally correctly optimized before).
> 
> -      return CmpInst::isFalseWhenEqual(Pred);
> +      return CmpInst::isFalseWhenEqual(FoundPred);
> 
> Pawel, you can merge these two revisions to get the right effect: r168711 + r168921

r168711 - Committed revision 168973.
r168921 - Committed revision 168974.

> 
> -Andy
> 
> 

Pawel