[llvm-commits] [PATCH] Add ARM cortex-a5 subtarget

[Quentin Colombet]

Hi Evan,

Thanks for the review.

I have removed the test case from the patch (new patch attached)

Thanks for the note on clang. It was my plan to send a patch to clang mailing list after this one is approved.

Quentin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cortex-a5.patch
Type: application/octet-stream
Size: 2346 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121129/e6449b1d/attachment.obj>
-------------- next part --------------


On Nov 29, 2012, at 11:31 AM, Evan Cheng <evan.cheng at apple.com> wrote:

> Hi Quentin,
> 
> The patch is fine. But I don't think the test case is appropriate or necessary.
> 
> Don't forget to update clang Driver/Tools.cpp and Basic/Targets.cpp.
> 
> Thanks,
> 
> Evan
> 
> On Nov 29, 2012, at 11:16 AM, Quentin Colombet <qcolombet at apple.com> wrote:
> 
>> Hello,
>> 
>> Here is a patch proposal to add the ARM cortex-a5 subtarget.
>> It mainly consists in adding the a target description in the ARM.td file and a test case using the new cpu name, thus nothing fancy.
>> 
>> Cortex A5 is more or less a Cortex A8 with VFP4 extensions.
>> 
>> Thanks for the reviews.
>> 
>> Quentin
>> <cortex-a5.patch>_______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>