[llvm-commits] [PATCH] [Fast-math] In relaxed FP mode, Instruction::isAssociative() returns true for fmul/fadd

[Eli Friedman]

On Wed, Nov 28, 2012 at 5:31 PM, Shuxin Yang <shuxin.llvm at gmail.com> wrote:
> Hi, Eli:
>
>     I understand how such mixed FP operator could take place. I misconstrue
> your previous mail about the the
> testing case. Currently it doesn't work (i.e mistakenly fold despite the one
> of the fp operator claimed as
> restrictive).
>
>    I don't try to lug everything in this single patch which is supposed to
> be a "enabler" for following work of
> bug/performance defect.
>
>    Please advise if I can "speculate" committing this change despite the
> some lurking bugs, or should I fix
> all this potential bugs before I can commit this patch.

You're probably going to have to audit every user of isAssociative to
make sure it does the right thing, but you don't have to do that
before you commit this.  Add the testcase anyway, and just put in a
FIXME instead of the CHECK lines.

-Eli