[llvm-commits] [llvm] r168532 - in /llvm/trunk: include/llvm/MC/MCDwarf.h lib/MC/MCDwarf.cpp lib/MC/MCStreamer.cpp

[Eric Christopher]

On Wed, Nov 28, 2012 at 1:00 PM, Jim Grosbach <grosbach at apple.com> wrote:

> Hi Rafael,
>
> One question below:
>
> > +    if (Dst.isReg()) {
> > +      assert(Dst.getReg() == MachineLocation::VirtualFP);
> > +      assert(!Src.isReg());
> > +      MCCFIInstruction Inst =
> > +        MCCFIInstruction::createDefCfa(Label, Src.getReg(),
> -Src.getOffset());
>
> The assert(!Src.isReg()) immediately followed by Src.getReg() seems odd.
> Is it correct? If so, can you add some comments and maybe a message to the
> asserts explaining what's actually going wrong if they fire?
>
>
Agreed, I was looking at it earlier and couldn't figure out what was meant
in 30 seconds or so. Some comments would be great :)

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121128/82ed03b6/attachment.html>